Skip to content

Share skills hook note post-processing#2679

Merged
mnriem merged 4 commits into
github:mainfrom
puneetdixit200:fix-skills-hook-note-postprocess
May 28, 2026
Merged

Share skills hook note post-processing#2679
mnriem merged 4 commits into
github:mainfrom
puneetdixit200:fix-skills-hook-note-postprocess

Conversation

@puneetdixit200
Copy link
Copy Markdown
Contributor

@puneetdixit200 puneetdixit200 commented May 22, 2026

Summary

  • Move hook command dot-to-hyphen note injection into shared skills post-processing.
  • Run shared post-processing during skills setup so generated skills stay consistent.
  • Keep per-integration frontmatter additions layered on top.

Fixes #2523

Tests

  • git diff --check
  • uvx ruff check src/
  • uv run python -m pytest tests/integrations/test_integration_base_skills.py tests/integrations/test_integration_claude.py tests/integrations/test_integration_copilot.py tests/integrations/test_integration_vibe.py tests/integrations/test_integration_codex.py tests/integrations/test_integration_agy.py tests/integrations/test_integration_devin.py tests/integrations/test_integration_cursor_agent.py tests/integrations/test_integration_kimi.py tests/integrations/test_integration_lingma.py tests/integrations/test_integration_trae.py -q
  • uv run pytest -q
  • uv run specify --help

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance: AI assistance helped inspect the integration flow and draft the implementation and tests. I reviewed the final diff and ran the checks listed above.

@puneetdixit200 puneetdixit200 requested a review from mnriem as a code owner May 22, 2026 18:16
Copilot AI review requested due to automatic review settings May 22, 2026 18:16
Copilot AI reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR centralizes “hook command dot-to-hyphen conversion” guidance by moving hook-note injection into the shared skills integration base, then updates integrations and tests to rely on the shared behavior.

Changes:

  • Add shared hook-note injection to the base skills post-processing pipeline.
  • Update Claude/Vibe/Copilot integrations to use base post-processing and remove duplicated logic.
  • Add/adjust integration tests to verify hook guidance appears only where expected and remains idempotent.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/integrations/test_integration_copilot.py Adds coverage that Copilot skills include shared hook guidance and still inject mode frontmatter.
tests/integrations/test_integration_claude.py Refactors tests to validate shared base behavior and removes Claude-specific injection calls.
tests/integrations/test_integration_base_skills.py Adds base-level test ensuring hook sections include dotted-command conversion guidance.
src/specify_cli/integrations/vibe/init.py Switches to base post-processing instead of bespoke post-generation rewriting.
src/specify_cli/integrations/copilot/init.py Injects hook guidance for Copilot skills (but not via super() yet).
src/specify_cli/integrations/claude/init.py Removes duplicated hook-note injector and delegates shared behavior to base post-processing.
src/specify_cli/integrations/base.py Introduces shared hook-note injection and applies post-processing during skill generation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/specify_cli/integrations/base.py
Comment thread src/specify_cli/integrations/base.py
Comment thread src/specify_cli/integrations/copilot/__init__.py Outdated
Comment thread src/specify_cli/integrations/base.py Outdated
@puneetdixit200
fix(integrations): tighten skill post-processing
ee96e39 
Apply skill content post-processing before the initial write, use an exact hook-note sentinel for idempotence, and route Copilot skill post-processing through the shared helper before adding mode frontmatter.
@mnriem mnriem requested a review from Copilot May 26, 2026 17:30
Copilot AI reviewed May 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 9/9 changed files
  • Comments generated: 2

Comment thread src/specify_cli/integrations/base.py Outdated
Comment thread src/specify_cli/integrations/codex/__init__.py Outdated
@mnriem mnriem requested a review from Copilot May 27, 2026 12:49
Copilot AI reviewed May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 9/9 changed files
  • Comments generated: 2

Comment thread src/specify_cli/integrations/codex/__init__.py Outdated
Comment thread src/specify_cli/integrations/vibe/__init__.py
mnriem
mnriem requested changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback. If not applicable, please explain why

@puneetdixit200
Copy link
Copy Markdown
Contributor Author

puneetdixit200 commented May 28, 2026

Follow-up verification on current head 4805463:

  • Confirmed CodexIntegration no longer defines its own hook-note helper, setup() override, or post_process_skill_content() override; it inherits the shared SkillsIntegration behavior.
  • Confirmed the Vibe post_process_skill_content() docstring now mentions shared hook guidance before the Vibe-specific flag.
  • Ran uv sync --extra test.
  • Ran uv run pytest tests/integrations/test_integration_codex.py::TestCodexHookCommandNote tests/integrations/test_integration_vibe.py tests/integrations/test_integration_base_skills.py -q - 37 passed.
  • Ran uv --project /Users/deepakkudi23/spec-kit-2679-verify run pytest /Users/deepakkudi23/spec-kit-2679-verify/tests/integrations -q - 1999 passed in 111.87s.
  • Ran uv run specify --help, uv run specify init --help, and git diff --check.

AI assistance disclosure: AI assistance was used for verification and drafting this status comment; I reviewed the code and command output before posting.

@mnriem mnriem requested a review from Copilot May 28, 2026 13:00
Copilot AI reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 9/9 changed files
  • Comments generated: 0 new

@mnriem mnriem self-requested a review May 28, 2026 14:07
@mnriem mnriem merged commit 5a678c5 into github:main May 28, 2026
11 checks passed
@mnriem
Copy link
Copy Markdown
Collaborator

mnriem commented May 28, 2026

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mnriem mnriem mnriem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lift hook command note injection into SkillsIntegration base class

3 participants

@puneetdixit200 @mnriem